[Developers] Re: Patch: [cctk_WarnLevel.h and WarnLevel.c]: to register the callbacks call them

[Tom Goodale]

On Fri, 27 May 2005, Jonathan Thornburg wrote:

> Hi,
>
> In a recent patch set, Jian Tao proposed
>> Four new functions are declared in cctk_WarnLevel.h together with the 
>> macros to enable users to register their own functions to  take care of 
>> Info/Warn message. The main purpose is to provide a generic interface to 
>> deal with Info/Warn message. 
>> A sample thorn is also ready and was used to test the those four functions.
>
> I have two concerns with this patch set:
>
> First, I'm unclear on the rationale for this change.
> That is, what problem are these patches attempting to address?

There have been several times when people have asked to be able to do more 
sophisticated things with error and info messages.  This provides a 
callback mechanism for thorns to provide their own handling;  e.g. putting 
them on a web-page, emailing, compiling a report, stopping the code when 
some combination of warnings/info messages occur, ...

> Second,
> <Jonathan-broken-record-mode>
> such a patch should also include updates to the Cactus Users' Guide
> and the Cactus Reference Manual describing the new APIs and why/how
> one might want to use them.
> </Jonathan-broken-record-mode>

Good point.

Tom