[Developers] Re: Patch: [cctk_WarnLevel.h and WarnLevel.c]: to register the callbacks call them

[Jonathan Thornburg]

Hi,

In a recent patch set, Jian Tao proposed
> Four new functions are declared in cctk_WarnLevel.h together with the macros 
> to enable users to register their own functions to  take care of Info/Warn 
> message. The main purpose is to provide a generic interface to deal with 
> Info/Warn message. 
> 
> A sample thorn is also ready and was used to test the those four functions.

I have two concerns with this patch set:

First, I'm unclear on the rationale for this change.
That is, what problem are these patches attempting to address?

Second,
<Jonathan-broken-record-mode>
such a patch should also include updates to the Cactus Users' Guide
and the Cactus Reference Manual describing the new APIs and why/how
one might want to use them.
</Jonathan-broken-record-mode>

ciao,

-- 
-- Jonathan Thornburg <jthorn at aei.mpg.de>
    Max-Planck-Institut fuer Gravitationsphysik (Albert-Einstein-Institut),
    Golm, Germany, "Old Europe"     http://www.aei.mpg.de/~jthorn/home.html
    "Washing one's hands of the conflict between the powerful and the
     powerless means to side with the powerful, not to be neutral."
                                       -- quote by Freire / poster by Oxfam