[Developers] Error in handling sync statements in scheduling groups

[Tom Goodale]

I see the problem now; when the synchronised flag was set, the resetting 
to 0 was not done in ScheduleCallExit.  Your solution works, but breaks 
the distinction between the attributes which are specific to a schedule 
item, and the data associated with the state of the schedular itself;  I 
think a better solution would have been to move the

   data->synchronised = 0

statement on line 2268 to outside the if statement.  Can you check if 
this fixes your problem ?

Cheers,

Tom

On Thu, 26 May 2005, Erik Schnetter wrote:

> On Thursday 26 May 2005 10:08, Frank Loeffler wrote:
>> Hi Erik,
>>
>> Erik Schnetter wrote:
>>> I just corrected a severe error in handling sync statements in
>>> scheduling groups in ScheduleInterface.c.
>>
>> Hat das was damit zu tun, dass die ASCII Ausgabe scheinbar nicht
>> gesynct war, obwohl ich nicht sah, warum?
>
> The symptom of the error was that certain ASCII output appeared
> unsynchronised, the reason being that it actually was unsynchronised.
> This concerned all quantities that are synchronised with sync
> statements for schedule groups.  (Sync statements for scheduled
> functions were fine.)
>
> As far as I can see, this concerns the thorn
>
> 	ADMConstraints
> 	BSSN_MoL, but only for the ADM_BSSN_cons variables
> 		(the BSSN variables and the excision mask were fine)
> 	BurgersToy (both in EUHydro_Dev and AEIDevelopment)
> 	MultiPatchAdvectionToy
>
> and maybe a few more.
>
> -erik
>
>