[Developers] Error in handling sync statements in scheduling groups

[Erik Schnetter]

I just corrected a severe error in handling sync statements in 
scheduling groups in ScheduleInterface.c.

Whether the synchronisation was done by CCTK_CallFunction or not was
stored in the "synchronised" flag of a t_sched_data object.  This
object exists only once for the simulation, and not once for each
recursive call of the scheduler when it traverses groups.  Thus the
information was correct only for the innermost schedule item, namely
functions, and incorrect for schedule groups.

Because PUGH does not overload CCTK_CallFunction, and thus this flag
always stays false, I assume that this error does not occur with PUGH
simulations.  It does occur with Carpet simulations.

As a quick solution, I moved the "synchronised" flag from the
t_sched_data structure into the t_attribute structure.  This does not
work for recursive calls.

It may be that the t_attribute structure is meant for unchanging
information.  In that case, it is necessary to construct a stack of
t_sched_data objects.

-erik

-- 
Erik Schnetter <schnetter at aei.mpg.de>   http://www.aei.mpg.de/~eschnett/

My email is as private as my paper mail.  I therefore support encrypting
and signing email messages.  Get my PGP key from www.keyserver.net.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.cactuscode.org/pipermail/developers/attachments/20050525/3f6db1e5/attachment-0002.bin