[Developers] patch: AEIThorns/BSSN_MoL: add new boundary option "nothing at all"

[Erik Schnetter]

On Monday 16 May 2005 13:03, Ian Hawke wrote:
> On Sat, 14 May 2005, Erik Schnetter wrote:
> >> * BSSN_MoL schedules code in src/Constraints.F in local mode, so
> >> it will run once for each patch... and this code calls
> >>     Boundary_SelectGroupForBC()  to register a boundary condition
> >
> > This routine needs to be called in level mode.  If necessary, the
> > calling function needs to be split.  Would this alone correct the
> > problem?
>
> This is not the only routine that would need fixing; the standard
> excision/boundary routines would also need fixing.
>
> >> I propose the enclosed patch to "fix" this behavior:
> >
> > [schnipp]
> >
> >> Are there any objections to my applying this patch?
> >
> > If scheduling things in level mode correct the problem, then this
> > should be done.  If the interactions between BSSN_MoL and Boundary
> > are too complex, then your workaround would be fine.
>
> Not necessarilly complex but certainly a mess; for those that enjoy
> suffering then the attached patch is, I believe, how the appropriate
> routines need splitting and the schedule rewriting. I believe this is
> the correct fix but have only tried it on the testsuites, nothing
> else.

The calling-forth-and-back between the scheduler and Fortran code is a 
pain.  Carpet already has functions like "CallLocalFunction" and 
"CallScheduleGroup" that allow you to write one single Fortran routine 
that calls alternatingly the Excision routines, the SelectBC routine, 
and the ApplyBC group.  If we turn these into aliased functions and 
provide dummy functions in PUGH, things would be much cleaner.

-erik

-- 
Erik Schnetter <schnetter at aei.mpg.de>   http://www.aei.mpg.de/~eschnett/

My email is as private as my paper mail.  I therefore support encrypting
and signing email messages.  Get my PGP key from www.keyserver.net.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.cactuscode.org/pipermail/developers/attachments/20050516/73876e85/attachment-0002.bin