[Developers] patch etiquette

Tom Goodale goodale at cct.lsu.edu
Wed May 11 05:58:49 CDT 2005



On Wed, 11 May 2005, Jonathan Thornburg wrote:

> Hi,
>
> Tom:
> | It would also be helpful for the patch approval process
> | if the patches are also sent in a seperate mail to me, so it is
> | easier for me to seperate discussion of patches from the patches
> | themselves.
>
> Erik:
>> I object to sending patches to Tom in separate emails.  Patches should
>> be review in public, and for that, everybody needs to see the patch.
>> Also, in order to review a patch, it is necessary to see both the patch
>> and the discussion about it.

I agree entirely, that's why I said "also".

>
> I would like to see the patches on the mailing list, so that I can
> follow what other people are proposing to change.  However, I'm happy
> to explictly also cc Tom on messages if that makes the process work
> better...

It will, although I'm trying to get a new patches mailing list setup which 
would just have patches in it, which would serve the same purpose.

Tom



More information about the Developers mailing list