[Developers] Patch for PR 1916: ThornGuide when arrangements are links

[Tom Goodale]

Looks good.  Please apply.

Could you also take a look at the other cases you've noticed ?  There have 
been various problems in the past with soft links, and this looks like hte 
best solution to date.

Cheers,

Tom

On Fri, 29 Apr 2005, Steve White wrote:

>
> Attached find a patch that effects a fix for PR 1916
>
>        patch -p0 < ThornGuide.diff
>
> Files changed
> -------------
>
> lib/sbin/ThornUtils.pm, lib/sbin/ThornList.pl
>
> (In both files, changed a FindDirectories function.)
>
> Main purpose
> ------------
>
> Links to arrangement directories are ignored by the ThornGuide build.
> This fixes that situation.
>
> Note
> ----
>
> The FindDirectories function in both files does the same thing although the 
> code looked rather different. It would be best to just use the one in the 
> package file.  I think there may be other examples of basically identical, 
> reinvented wheels in the code.
>
> The main improvement in the patch is that instead of relying on the formatted 
> output of the shell command 'ls', I use the Perl commands 'opendir, readdir', 
> a technique with several advantages, among which being that it is more 
> robust.  I see there are several other cases of the use of the 'ls' technique 
> in the Cactus code--maybe these should be scrutinised.
>
>
> ------------------------------------------------------------------------
> Steve White : Programmer
> Max-Planck-Institut für Gravitationsphysik      Albert-Einstein-Institut
> Am Mühlenberg 1, D-14476 Golm, Germany                  +49-331-567-7625