[Developers] CactusExternal/HDF5 is dangerous

[Thomas Radke]

Erik Schnetter wrote:
> On Friday 29 April 2005 20:01, Thomas Radke wrote:
> 
>>You don't need to do this yourself in your thorn's configuration.ccl.
>>It's done automagically by the CST (Tom, please correct me if I'm
>>explaining your code wrong).
> 
> 
> At CST time, I see the messages
> 
> Running configuration script 
> '/home/eschnett/Calpha/Cactus/arrangements/CactusExternal/HDF5/hdf5.sh'
>   HDF5 selected but no HDF5_DIR set. Checking some places...
>   Found an HDF5 package in /usr
>   Found parallel HDF5 library, so Cactus will potentially make use of 
> parallel HDF5 support.
> 
> That does not sound like "HDF5 directory setting is remembered".

Sorry, this is a real bug. It only remembered HDF5_DIR if it was given 
by the user explicitely (not auto-detected by the config script).

There seems to be a design flaw in the configuration scripts that they 
cannot pass auto-detected settings back to the calling CST script which 
then would save them in a config options file.
For now I fixed the HDF5 config script in CactusExternal/HDF5/ to 
remember the HDF5_DIR setting in its own generated makefile include. It 
will be checked for and reused in following invocations if HDF5_DIR is 
left empty by the user.


-- 
Cheers, Thomas.