[Developers] Fix for Bug Report 1864.

Jonathan Thornburg jthorn at aei.mpg.de
Wed Jun 22 05:52:44 CDT 2005


Hi,

On Tue, 21 Jun 2005 smadiraju at cct.lsu.edu wrote:
> I am attaching the file which fixes the bug 1864.

Could you please send this patch to the   patches at cactuscode.org
mailing list (and in general, could everyone please cc *all* patches
to that list)?  The other lists cactus lists (like developers@) are
now apparently configured to strip off the patches (at least I don't
see any patch with the message I got from developers@ to which this
is a reply), so without the cc to patches@, there's no way for anyone
other than the sender to see the patch!


> The patch makes sure that when
> a directory is passed as input instead of a .par file, to the cactus
> executable
> it flags an error. If the fix is not present then the directory input is
> accepted and nothing happens.
>
> The fix involves using the stat function in C which fill a buffer with
> all the
> information about the file that is passed. Then we use a S_ISDIR macro
> to test
> if the file name passed is a directory. If it is a directory then an
> error is
> flagged.

stat()  and S_ISDIR  are in Posix, but are they in the non-Unix
platforms (Mac, Windoze)?  We may need a configure test to check this,
since otherwise cactus would fail to compile on systems where these
aren't defined.

ciao,

-- 
-- Jonathan Thornburg <jthorn at aei.mpg.de>
    Max-Planck-Institut fuer Gravitationsphysik (Albert-Einstein-Institut),
    Golm, Germany, "Old Europe"     http://www.aei.mpg.de/~jthorn/home.html
    "Washing one's hands of the conflict between the powerful and the
     powerless means to side with the powerful, not to be neutral."
                                       -- quote by Freire / poster by Oxfam




More information about the Developers mailing list